this is definitely trap, that melody was on point. I don't really mind the effects because normally trap music is full of them now when the artist jumps on the beat. Im really seeing improvement on your part, keep it coming!
i like the beat but it needs more in the higher frequency range, i also think the snare is a bit soft in the mix. With those fixed itll be an excellent beat.