Everyone has different tastes. I'll share my opinion:
It sounds a little like an amateur band in a garage. But I think that's almost entirely the mix, and a lot can be done to fix it.
- The drums are too loud, relative to everything else.
- The entire mix is missing high end, from the snare to the hat to the guitars - bring out some sparkle and some snap and some grit!
- Guitars should be louder.
- The vocals sound very distant, likely due to the heavy vocal effects - is this a stylist choice?
- Are you putting the reverb directly on the vocal track? Or playing the vocals clean direct to the master bus, and separately routing the vocals to a reverb bus? The second will sound clearer and more pro.
There are some things I like:
- The musicianship feels really tight, very in-sync.
- The guitars are spread nicely, doubled nicely.
- It's arranged well - you have a good sense of which instruments should be sounding at what point, and what they are playing.
I think your composition is well written and arranged and performed. It's the mix that needs work. I'd focus a long time on EQing everything just so. Compare to a great sounding reference track, instrument by instrument. Does your snare sound as crisp as their snare? If not, adjust. Does your lead guitar sound as edgy as their lead guitar? If not, adjust. Etc.
Greg Wells recently put out a plugin with Waves called VoiceCentric, supposed to be a one-stop-shop for vocal mixing for many pop tunes. Now, there are serious limitations from what is close to a one-knob plugin. But, in advertising it, he disclosed his typical vocal chain: input > EQ > de-esser > fast compression > slow compression > output. But also, slow compression separately runs to adjustable amounts of delay, reverb, and doubling, which each separately go to the output. Try mixing your vocal this way, see if it sits better.
- For the doubler, crank it until it sounds nasty, then slowly dial it down to where you like it. I often like it just below where that phasey-ness stops, but it still makes the vocal sound thicker and more pro.
- Your vocal delay sounds a little slappy, a little like what Elvis used. Try making it quieter, cut the lows and highs from it (leaving it mid-range), and play with how long the delay is. You may find you like the volume just below what's audible on an average system, yet you still feel something is missing when you mute it.
- Reverb often sounds best dark and midrange-y too. You could try a medium-short length verb that just hugs the vocals, only slightly audible. And then a much longer dark reverb (also low in volume) to make the room feel bigger. Use a touch of pre-delay on the short verb, and more pre-delay on the longer verb.
- Unless you're going for something tricky, always run the vocal output (with tuning, EQ, compression) straight to the rest of the mix bus or master bus, and separately route the vocal through effects (delay, reverb, doubling, etc.). Have each effect 100% wet, then just dial in the volume of each effects channel to where it sounds good: supporting but not overwhelming.
Best wishes.