good is a matter of style and preference, but listen to the music you think has a good beat and disect it. Try to figure out what gives it that swing. Try playing on a drumset and you'll pick up a lot. in hip hop and most of rock and pop, the core of the beat is the kick and the snare (a clap can be used to fill the function of the snare, though thats been real overused recently due to people copying kanye) cymbals and hats basically keep time in hip hop, in rock, they are used for fills and in transitions a lot and often hit every beat or on all eighth notes or sumn. just play with that stuff for a while in Fruityloops or on a drumset for a while, cuz it takes time to pick it up. if you're looking for more advanced stuff, look at programming the drums to the front or the back of the beat and using ghost notes and pay attention to programming the velocity of individual hits. good drum sounds are also really important. a good producer spends time building a library of sounds to work with (sampling, diggin ya know). basically you gotta work at it to get it, but if it makes you feel good, makes your head nod, whatever, then its good.